Skip to content

Conversation

@OldHCF
Copy link
Contributor

@OldHCF OldHCF commented May 31, 2025

General:

  • The pull request title is descriptive. (ex. Added GoldenPvP Network, not Updated metadata.json)
  • The pull request does not contain any unrelated commits. (ex. commits from previous pull requests)

Mapping Additions or Updates:

  • Folder with appropriate name has been created / updated (must not include any non-alpha characters or whitespace).
  • No changes were made to the file's formatting (4 spaces per tab).
  • There are no syntax errors.
  • There is no pre-existing mapping matching my id (check if there is an existing folder).
  • My field values match your requirements.
  • You can view our patterns here: metadata.schema.json, or take a look below and complete the field checklist:
    • id: a lowercase string, which should match the folder name (ex. goldenpvpnetwork)
    • name: a string (ex. GoldenPvP Network)
    • description: between 16 and 50 characters (ex. We're the home of classic PvP gamemodes)
    • addresses: an array with lowercase strings (ex. ["goldenpvp.net", "routing.center"])
      • You do not need to specify subdomains, CheatBreaker services automatically detect them.
    • primaryAddress: the primary address that people connect to with (please include the subdomain if required) (ex. mc.goldenpvp.net)
    • minecraftVersions: an array with Minecraft versions as strings (ex. ["1.7.*", "1.8.9"] - Must be versions or subversions supported by CheatBreaker)
    • primaryMinecraftVersion: a Minecraft version as a string (ex. 1.7.10 - Must be a subversion supported by CheatBreaker)
    • primaryColor: a hexademical color code that primarily distinguishes the server (ex. #00FFFF)
    • secondaryColor: a hexademical color code that accompanies the primaryColor of the server (ex. #FF0000)
    • primaryRegion: the primary region where your server operates in (ex. EU)
    • regions: a list of regions where you have servers located that service your players (ex. ["EU", "NA", "AS"])
    • gameTypes: a list of games that describe the content on your server, must be a max of 3 listed (ez. ["PVP", "UHC", "HCF"])
    • (optional) website: url of server website, must include URL schema (http:// or https://) (ex. https://www.goldenpvp.net)
    • (optional) store: url of server store, must include URL schema (http:// or https://) (ex. https://store.goldenpvp.net)

Socials

  • (optional) twitter: username of twitter account without the @ (ex. GoldenPvPNet)
  • (optional) discord: invite link to discord (ex. https://discord.com/invite/3EAzBxf)
  • (optional) youtube: slug or username of youtube channel (ex. GoldenPvP)
  • (optional) instagram: username of instagram account (ex. GoldenPvPNet)
  • (optional) twitch: username of twitch account (ex. GoldenPvPNet)
  • (optional) telegram: slug of telegram group (ex. GoldenPvP-Network)
  • (optional) reddit: slug of subdreddit wtih 'r/' (ex. GoldenPvP)
  • (optional) tiktok: username of tiktok account (ex. GoldenPvP)
  • (optional) facebook: slug of facebook page (ex. GoldenPvP)

Media:

Icon

  • My icon is a png file.
  • I have uploaded my icon to my server folder (ex. goldenpvpnetwork) and named it icon.png.
  • My icon has a transparent background and is square (1:1 aspect ratio).
  • My icon is 64 pixels in width and height.
  • My icon is my own/the server's property and complies with relevant copyright/privacy laws.

Logo

  • My logo is a png file.
  • I have uploaded my logo to my server folder (ex. goldenpvpnetwork) and named it logo.png.
  • My logo has a transparent background and is square (1:1 aspect ratio).
  • My logo is 108 pixels in width and height.
  • My logo is my own/the server's property and complies with relevant copyright/privacy laws.

Discord Logo

  • My logo is a png file.
  • I have uploaded my logo to my server folder (ex. goldenpvpnetwork) and named it discord.png.
  • My logo has a transparent background and is square (1:1 aspect ratio).
  • My logo is between 512 and 1024 pixels in width and height.
  • My logo is my own/the server's property and complies with relevant copyright/privacy laws.

Background

  • My background is a png file.
  • I have uploaded my background to my server folder (ex. goldenpvpnetwork) and named it primarybackground.png.
  • My background has an aspect ratio of 16:9.
  • My background contains relevant content pertaining to the server, is my own/the server's property, and complies with relevant copyright/privacy laws.
  • My background doesn't contain any markings, text, or logos (unless part of a build).

Signed-off-by: ONE-EDUARDO <[email protected]>
@ShonP40
Copy link
Member

ShonP40 commented Jun 15, 2025

Check all the boxes relevant to your PR

@OldHCF
Copy link
Contributor Author

OldHCF commented Jun 15, 2025

You still didn't check all the relevant boxes. Read each one and check it if relevant.
already

@ShonP40
Copy link
Member

ShonP40 commented Jun 15, 2025

  1. PRs must be in English
  2. You still didn't check all the relevant boxes. Read each one and check it if relevant.

@OldHCF
Copy link
Contributor Author

OldHCF commented Jun 15, 2025

  1. PRs must be in English
  2. You still didn't check all the relevant boxes. Read each one and check it if relevant.
    already

Copy link
Member

@ShonP40 ShonP40 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to my comments on the files you submitted, you're also missing a server background
Read more here: https://docs.cheatbreaker.net/server-mappings/adding-servers/background

OldHCF and others added 2 commits June 18, 2025 12:36
Update discord invite

Signed-off-by: ONE-EDUARDO <[email protected]>
@ShonP40
Copy link
Member

ShonP40 commented Jun 20, 2025

The problematic file is logo.png, not discord.png...

@OldHCF
Copy link
Contributor Author

OldHCF commented Jun 20, 2025

The problematic file is logo.png, not discord.png...

sorry

@ShonP40
Copy link
Member

ShonP40 commented Jun 30, 2025

This will soon be closed for inactivity unless you submit fixes for the requested changes

OldHCF added 2 commits July 1, 2025 11:45
It is to upload the 108x108 logo

Signed-off-by: oldHCF <[email protected]>
This is the 108x108 logo

Signed-off-by: oldHCF <[email protected]>
Copy link
Member

@ShonP40 ShonP40 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As stated earlier, you're still missing a background

Read more here: https://docs.cheatbreaker.net/server-mappings/adding-servers/background

This is the last thing required to have the server added.

Copy link
Member

@ShonP40 ShonP40 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As stated earlier, you're still missing a background

Read more here: https://docs.cheatbreaker.net/server-mappings/adding-servers/background

This is the last thing required to have the server added.

This PR will be closed in a week unless you submit a background.

Signed-off-by: oldHCF <[email protected]>
@ShonP40 ShonP40 merged commit 4871fb3 into CheatBreakerNet:master Jul 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants